Fixed _servletDispatchRequest() to check for non-null WOResponse content... #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent stream as well as non-null content data.
|
+1 This fixes a problem I ran into long time ago :-) |
darkv
added a commit
that referenced
this pull request
May 6, 2015
Fixed _servletDispatchRequest() to check for non-null WOResponse content...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a servlet deployment, if you are setting a content stream on the response (e.g. for streaming binary data), the response does not return any data due to a faulty conditional that checks for available content. This fix amends that conditional to check to also check for a non-null input stream as well as non-empty content data.