support big responses for Apache 2 adaptor #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Johann. What is the environment you use in production? We will move to Debian 7 with Apache 2.4 so I was wondering… |
|
Hi Philippe, using Ubuntu 14 with Apache 2.4 for that specific application. |
darkv
added a commit
that referenced
this pull request
Apr 27, 2015
support big responses for Apache 2 adaptor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Apache adaptor uses an unsigned int to store the content length reported by the WO application for a response. If you provide big files (read really big files) for streamed download the content length causes an integer overflow resulting in a wrong content length. Thus the download will be interrupted before completion.
This pull request parses the content length as long and changes the respective variable types to long types. This change has been successfully tested with Apache 2.2 and 2.4 on a productive application with high download traffic.