-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update H2 to current version and create SQL-92 join clauses #577
Conversation
fbarthez
commented
May 10, 2014
- updated H2 to current version 1.4.177, the old version throws an SQL error when dropping (former) foreign key columns
- replaced implementation of assembleSelectStatementWithAttributes() with code from PostgresqlExpression that generates SQL-92 compatible join clauses, making left outer joins work
- added catch clause for an IllegalArgumentException that occurred when no sequence existed yet
… yet * generate SQL-92 join clauses to allow for left joins; code stolen from PostgresqlPlugIn with minor changes to remove identifier quoting
Be aware that the current H2 version in Wonder is the latest one that still supports Java 5. Beginning with 1.3.169 it is Java 6 only. |
Thanks, Johann, I wasn't aware of that. Turns out, the version set in the pom was 1.2.125. The problem I ran into was fixed in 1.3.151. So, I've reverted the commit and created a new one that only changes the version in the pom to 1.3.168, the same that's used for the ant build. |
We should update wonder to Java6. Why on earth we are using Java5? |
Six? What about Java 8? :-) |
Java 6 or 7 (or 8) should be for Wonder 7.0.0 release making it a clear you-must-update-your-own-code-update ;) |
One step after the next. first 6, && then lets think about it. but Java5 is^^ 😂 |
The significant, and potentially troublesome, changes were in Java 8. An update to Java 7 makes more sense to me than Java 6. Even I don't use Java 5! |
Yes we should go Java7 very soon, but like I said we should go to 6 first, and then give the people time to upgrade the deploy environment to Java 7. so a time limit, Start 1.1.2015 Java7 only. |
How about keep Wonder 6 at Java 5 so nobody has to change anything but begin with Wonder 7 branch with Java 7 soon? What real benefits would there be to update to Java 6 for the current branch if we will have a shiny Wonder 7 in the short term? ;) |
shiny Wonder ? haha |
I will try to set up a Wonder 7 branch in the next couple of weeks so we can safely merge those pull requests into it. Wonder 6 can stay on the same system requirements for legacy reasons and everyone can decide to either stay on that version or move on. Such a change should not be made in a small point release IMHO. |
This particular pull request will work fine for Java 5. After Johann's remark I modified it to update the maven pom to the same H2 version (1.3.168) that's used in the ant build. |
Update H2 to current version and create SQL-92 join clauses