Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update H2 to current version and create SQL-92 join clauses #577

Merged
merged 4 commits into from
Jan 15, 2015

Conversation

fbarthez
Copy link
Contributor

  • updated H2 to current version 1.4.177, the old version throws an SQL error when dropping (former) foreign key columns
  • replaced implementation of assembleSelectStatementWithAttributes() with code from PostgresqlExpression that generates SQL-92 compatible join clauses, making left outer joins work
  • added catch clause for an IllegalArgumentException that occurred when no sequence existed yet

… yet

 * generate SQL-92 join clauses to allow for left joins; code stolen from PostgresqlPlugIn with minor changes to remove identifier quoting
@darkv
Copy link
Member

darkv commented May 11, 2014

Be aware that the current H2 version in Wonder is the latest one that still supports Java 5. Beginning with 1.3.169 it is Java 6 only.

@fbarthez
Copy link
Contributor Author

Thanks, Johann, I wasn't aware of that. Turns out, the version set in the pom was 1.2.125. The problem I ran into was fixed in 1.3.151. So, I've reverted the commit and created a new one that only changes the version in the pom to 1.3.168, the same that's used for the ant build.

@ishimoto
Copy link
Contributor

We should update wonder to Java6. Why on earth we are using Java5?
Who is the crazy one that don't let it do. Come on, let's move on.

@ghost
Copy link

ghost commented Aug 12, 2014

Six? What about Java 8? :-)

@darkv
Copy link
Member

darkv commented Aug 12, 2014

Java 6 or 7 (or 8) should be for Wonder 7.0.0 release making it a clear you-must-update-your-own-code-update ;)

@ishimoto
Copy link
Contributor

One step after the next. first 6, && then lets think about it. but Java5 is^^ 😂

@ghost
Copy link

ghost commented Aug 12, 2014

The significant, and potentially troublesome, changes were in Java 8. An update to Java 7 makes more sense to me than Java 6. Even I don't use Java 5!

@ishimoto
Copy link
Contributor

Yes we should go Java7 very soon, but like I said we should go to 6 first, and then give the people time to upgrade the deploy environment to Java 7. so a time limit, Start 1.1.2015 Java7 only.

@darkv
Copy link
Member

darkv commented Aug 12, 2014

How about keep Wonder 6 at Java 5 so nobody has to change anything but begin with Wonder 7 branch with Java 7 soon? What real benefits would there be to update to Java 6 for the current branch if we will have a shiny Wonder 7 in the short term? ;)

@ishimoto
Copy link
Contributor

shiny Wonder ? haha
but with Java5 there are pull requests that can be pulled.
But whatever you like to do, it is not my decision.
I stopped using wonder 2 months ago and work on my own Branch wonder Branch with lot's of fixe and improvements.

@darkv
Copy link
Member

darkv commented Aug 12, 2014

I will try to set up a Wonder 7 branch in the next couple of weeks so we can safely merge those pull requests into it. Wonder 6 can stay on the same system requirements for legacy reasons and everyone can decide to either stay on that version or move on. Such a change should not be made in a small point release IMHO.

@fbarthez
Copy link
Contributor Author

This particular pull request will work fine for Java 5. After Johann's remark I modified it to update the maven pom to the same H2 version (1.3.168) that's used in the ant build.

@darkv darkv added Wonder7 and removed Wonder7 labels Jan 10, 2015
darkv added a commit that referenced this pull request Jan 15, 2015
Update H2 to current version and create SQL-92 join clauses
@darkv darkv merged commit e424c12 into wocommunity:master Jan 15, 2015
@fbarthez fbarthez deleted the H2-SQL-92 branch January 15, 2015 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants