When trimming spaces, skip read-only attributes. #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As bonus question: did you check what happens if the whole entity has been set to read-only instead of a specific attribute? |
|
No, I didn't, but I imagine it'll throw as with a read-only attribute. I added a check for that case in a new commit. Am 15.01.2014 um 09:34 schrieb Johann Werner notifications@github.com:
|
|
Thanks for your update. This could be further optimized, will do that in a separate commit. |
darkv
added a commit
that referenced
this pull request
Jan 16, 2014
When trimming spaces, skip read-only attributes.
darkv
added a commit
that referenced
this pull request
Jan 16, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.