Extract the construction of count distinct expression into its own method #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thod This is a small refactoring (no changes in behavior) allowing concrete implementations of ERXSQLHelper class to provide their own mechanism to construct the SQL expression to count distinct rows. The default implementation doesn't support composite primary keys. Concrete implementations of ERXSQLHelper may override the `sqlForCountDistinct` method to change this behavior according to each database syntax.
This was referenced Sep 11, 2013
hprange
added a commit
that referenced
this pull request
Sep 12, 2013
Extract the construction of count distinct expression into its own method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small refactoring (no changes in behavior) allowing concrete implementations of ERXSQLHelper class to provide their own mechanism to construct the SQL expression to count distinct rows. The default implementation doesn't support composite primary keys. Concrete implementations of ERXSQLHelper may override the
sqlForCountDistinctmethod to change this behavior according to each database syntax.