-
Notifications
You must be signed in to change notification settings - Fork 166
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
hide date picker if field is disabled or readonly
- Loading branch information
Showing
1 changed file
with
6 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c0bd26a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always set the date field to readonly to user cannot enter invalid dates using keyboard... Now, they won't even be able to enter dates with the calendar. I support the new behaviour for the disabled binding though.
Unless someone has a better solution, please restore the picker for readonly field.
c0bd26a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested some cases and there is a difference between setting the readonly binding and adding the attribute using otherTagString = "readonly".
When setting the readonly binding, the value is not processed anyway but with otherTagString, it is and I used the otherTagString way so your commit does not break my apps. I do not understand where the difference come from though.
My memory was not precise enough...
c0bd26a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For your use case I would suggest to make a new boolean binding like manualInput so the intended behavior is clear. Using the readonly binding to achieve that seems wrong.
c0bd26a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added that feature in 6bc5a92