Switch to integer data type in Eigen test for default arguments #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `test10_eigen_scalar_default` test in `test_eigen.py` relies unnecessarily on exact equality of floating point numbers. In my environment, with a recent commit of Eigen, the addition in the test is causing the equality check to fail. There might be other upstream issues to consider here, but the specific test failure here seems to be a false positive! This PR switches that test to use integer zeros to be less sensitive to numerics. Let me know what you think - thanks!
|
Closing because there's probably some other issue with my environment. Sorry for the noise! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
test10_eigen_scalar_defaulttest intest_eigen.pyrelies unnecessarily on exact equality of floating point numbers. In my environment, with a recent commit of Eigen, the addition in the test is causing the equality check to fail. There might be other upstream issues to consider here, but the specific test failure here seems to be a false positive! This PR switches that test to use integer zeros to be less sensitive to numerics. Let me know what you think - thanks!