Add layout.insets option #7416
Merged
Add layout.insets option #7416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into layoutInsets
In order to propagate to other view and they will apply then if needed
|
Thanks @yogevbd for the fix, just one more issue, setting |
|
That's right, @swabbass we should resolve |
swabbass
added a commit
that referenced
this pull request
Jan 6, 2022
commit b8d7472 Author: wixmobile <mobile1@wix.com> Date: Tue Jan 4 01:09:08 2022 -0800 Update package.json version to 7.25.0 [buildkite skip] commit 9bb70d8 Author: Yogev Ben David <yogev132@gmail.com> Date: Tue Jan 4 10:09:17 2022 +0200 Add layout.insets option (#7416) This feature allows adding insets to the topmost view controller in the hierarchy, it is useful for presenting a banner across the app with overlay without having to re-render it each time a new screen is being pushed. Co-authored-by: Ward Abbass <swabbass@gmail.com> commit 403fcf1 Author: igorgn <50628426+igorgn@users.noreply.github.com> Date: Mon Jan 3 13:46:50 2022 +0200 Archive artifacts (#7417) * archive artifacts * e2e archiving commit 6380c29 Author: Ward Abbass <swabbass@gmail.com> Date: Tue Dec 28 13:46:39 2021 +0200 Exclude android unit tests for non playground projects (#7415) Exclude android native unit tests and their dependencies from being passed to other projects.
swabbass
added a commit
that referenced
this pull request
Jan 6, 2022
commit b8d7472 Author: wixmobile <mobile1@wix.com> Date: Tue Jan 4 01:09:08 2022 -0800 Update package.json version to 7.25.0 [buildkite skip] commit 9bb70d8 Author: Yogev Ben David <yogev132@gmail.com> Date: Tue Jan 4 10:09:17 2022 +0200 Add layout.insets option (#7416) This feature allows adding insets to the topmost view controller in the hierarchy, it is useful for presenting a banner across the app with overlay without having to re-render it each time a new screen is being pushed. Co-authored-by: Ward Abbass <swabbass@gmail.com> commit 403fcf1 Author: igorgn <50628426+igorgn@users.noreply.github.com> Date: Mon Jan 3 13:46:50 2022 +0200 Archive artifacts (#7417) * archive artifacts * e2e archiving commit 6380c29 Author: Ward Abbass <swabbass@gmail.com> Date: Tue Dec 28 13:46:39 2021 +0200 Exclude android unit tests for non playground projects (#7415) Exclude android native unit tests and their dependencies from being passed to other projects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature allows adding insets to the topmost view controller in the hierarchy, it is useful for presenting a banner across the app with overlay without having to re-render it each time a new screen is being pushed.