Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issue with border shown on iOS TopBar #6548

Merged
merged 1 commit into from
Sep 9, 2020
Merged

Fixes issue with border shown on iOS TopBar #6548

merged 1 commit into from
Sep 9, 2020

Conversation

mateioprea
Copy link
Collaborator

@mateioprea mateioprea commented Sep 8, 2020 •
edited
Loading

Fixes issue with border shown on iOS TopBar in combination with largeTitle {visible: true}, even though {noBorder:true} is passed in the config

@mateioprea
Copy link
Collaborator Author

@guyca can you help with reviewing this? Thank you!

@mateioprea
Copy link
Collaborator Author

Also, I can show you a before and after screenshot for this one you if you want. Maybe @yogevbd can look into it if @guyca is busy. Thank you!

@yogevbd yogevbd merged commit 29365dc into wix:master Sep 9, 2020
@yogevbd
Copy link
Collaborator

yogevbd commented Sep 9, 2020

Hey @mateioprea thanks a lot for the PRs! 🙇
Ping me on Discord so I can process your contributions faster, My handle is yogevbd!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yogevbd yogevbd yogevbd approved these changes

Assignees
No one assigned
Labels
platform: iOS type: accepted/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mateioprea @yogevbd