Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix component generator called multiple times #6239

Merged
merged 4 commits into from
May 25, 2020
Merged

Fix component generator called multiple times #6239

merged 4 commits into from
May 25, 2020

Commits on May 21, 2020

  1. Initial commit 

    Fix registered component generator function called multiple times. Apparently this hasn't resulted in actual bugs, but it's unpredictable behaviour which can easily lead to bugs and issues.

This commit caches registered components so they are created only once.
    @guyca
    guyca committed May 21, 2020
    Configuration menu
    Copy the full SHA
    ec66a8b View commit details
    Browse the repository at this point in the history

Commits on May 24, 2020

  1. Test component generator is invoked once

    @guyca
    guyca committed May 24, 2020
    Configuration menu
    Copy the full SHA
    13a6c3e View commit details
    Browse the repository at this point in the history

Commits on May 25, 2020

  1. Component is wrapped only once

    @guyca
    guyca committed May 25, 2020
    Configuration menu
    Copy the full SHA
    dc4e3c3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into componentProviderFixes

    @yogevbd
    yogevbd authored May 25, 2020
    Configuration menu
    Copy the full SHA
    641e683 View commit details
    Browse the repository at this point in the history