Fix button with react component doesn't get unmounted #5457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yogevbd
added a commit
that referenced
this pull request
Sep 5, 2019
* Fix button with react component doesn't get unmounted * Test e2e only on iOS
vshkl
pushed a commit
to vshkl/react-native-navigation
that referenced
this pull request
Feb 5, 2020
* Fix button with react component doesn't get unmounted * Test e2e only on iOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merging
topBarbutton with react component and then merging again with another button, the react component didn't get unmounted which caused detox tests to hang when setting loader component in buttons.