Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't cache values for constants() call #5442

Merged
merged 3 commits into from
Sep 5, 2019
Merged

Don't cache values for constants() call #5442

merged 3 commits into from
Sep 5, 2019

Commits on Sep 2, 2019

  1. Don't cache values for constants() call 

    The reason we can not cache the values is because the implementation differs per OS. Android returns static values while iOS will actually crawl the layout and return it's heights. The caching mechanism here meant that iOS would only return the heights of the layout it calculated the first time.
    Alberto Blanco committed Sep 2, 2019
    Configuration menu
    Copy the full SHA
    7646296 View commit details
    Browse the repository at this point in the history

  2. Update docs regarding inconsistencies in Constants

    Alberto Blanco committed Sep 2, 2019
    Configuration menu
    Copy the full SHA
    0d45cee View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2019

  1. Merge branch 'master' into 5439-constants-values-cached

    @guyca
    guyca authored Sep 5, 2019
    Configuration menu
    Copy the full SHA
    b057613 View commit details
    Browse the repository at this point in the history