Adding hideNavBarOnFocusSearchBar option #4578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did someone get a chance to look at this small PR? This is very important feature for one the components we build. Right now, user have to use multiple clicks (one for cancel and other for nav button) in order to accomplish a functionality. After this fix, they can use nav button directly and ignore the cancel. I want this to be merged asap. Thanks. |
vshkl
pushed a commit
to vshkl/react-native-navigation
that referenced
this pull request
Feb 5, 2020
* hidesNavigationBarDuringPresentation SearchBar * Adding hideNavBarOnFocusSearchBar option * Fixing compilation error * Code cleanup * code refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will allow the user to add a new property to the
topBaroptionshideNavBarOnFocusSearchBarhideNavBarOnFocusSearchBaris false then the nav bar wont hide on focus the search bar.hideNavBarOnFocusSearchBaris true or don't have this property mentioned in thetopBaroptions then it will work as existing.