Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom tabs affected by layout backgroundColor #7455

Closed
kevinwaelkens opened this issue Feb 11, 2022 · 5 comments · Fixed by #7471
Closed

Bottom tabs affected by layout backgroundColor #7455

kevinwaelkens opened this issue Feb 11, 2022 · 5 comments · Fixed by #7471

Comments

@kevinwaelkens
Copy link

🐛 Bug Report

When adding a layout backgroundColor to the navigation options, the bottom tabs are affected by it. This means that when you add a layout backgroundColor 'white', the bottom tabs will be completely white. For that reason I applied a semi-transparent color as backgroundColor so you can still see the bottom tabs.

To Reproduce

  1. Run the playground application
  2. Notice the bottomTabs are only 50% visible because there's a 50% red color overlay.
  3. Change the backgroundColor: 'rgba(255,0,0, .5)' to eg. backgroundColor: 'white', and notice the bar is fully white.

Expected behavior

I expect the bottomTab buttons to be visible.

Actual Behavior

The bottomTab buttons are affected by the backgroundColor of the layout property.

Screenshot 2022-02-11 at 19 27 27

Your Environment

  • React Native Navigation version: 7.25.3
  • React Native version: 0.66.3
  • Platform(s) (iOS, Android, or both?): Android
  • Device info (Simulator/Device? OS version? Debug/Release?): Android Emulator Android 12 API 31

Reproducible Demo

https://github.com/kevinwaelkens/react-native-navigation/tree/bug/bottom-tabs-disappearing

Are you willing to resolve this issue by submitting a Pull Request?

  • ✖️   Yes, I have the time, and I know how to start.
  • ✅   Yes, I have the time, but I don't know how to start. I would need guidance.
  • ✖️   No, I don’t have the time and I’m okay to wait for the community / maintainers to resolve this issue.
@SYoder1
Copy link

SYoder1 commented Feb 11, 2022

After updating to 7.25.3 I am seeing the exact same issue.

@agestaun
Copy link

agestaun commented Feb 23, 2022

Same problem here. If I remove the background layout, I can see the content of the previous screen while I push another screen. Solutions?

@ghashi
Copy link

ghashi commented Feb 24, 2022

version 7.25.1 is ok

@yogevbd yogevbd mentioned this issue Feb 28, 2022
@yogevbd
Copy link
Collaborator

yogevbd commented Feb 28, 2022

@kevinwaelkens could you please test it with 7.26.0-alpha.1? it should be stable

@yogevbd yogevbd self-assigned this Feb 28, 2022
yogevbd added a commit that referenced this issue Feb 28, 2022
Some PR's caused many bugs on Android, we decided to revert those PR's in order to have better stability.

Closes #7455
Adresses #7420
Adresses #7433

Co-authored-by: wixmobile <mobile1@wix.com>
@kevinwaelkens
Copy link
Author

@kevinwaelkens could you please test it with 7.26.0-alpha.1? it should be stable

Confirmed it works, thanks for this! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants