Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support 'fontSize' on OptionsTopBarButton #6405

Closed
oferRounds opened this issue Jul 19, 2020 · 5 comments · Fixed by #6443
Closed

Support 'fontSize' on OptionsTopBarButton #6405

oferRounds opened this issue Jul 19, 2020 · 5 comments · Fixed by #6443
Assignees
@guyca
Labels
platform: Android type: accepted/bug type: documentation

Comments

@oferRounds
Copy link

font family and font weight are supported, is there a reason why font size is not?

Thank you!
@guyca
Copy link
Collaborator

guyca commented Jul 19, 2020

Hey @oferRounds 👋
This probably get left out by mistake - go ahead and PR this

@oferRounds
Copy link
Author

Got you, will do

@oferRounds oferRounds changed the title Support 'fontSize' to OptionsTopBarButton Support 'fontSize' on OptionsTopBarButton Jul 19, 2020
@stachu2k
Copy link

Yup. I can confirm, but it was working on version 6.0.0. After upgrading to 6.10.1 fontSize property in rightButtons stopped working.

@guyca
Copy link
Collaborator

guyca commented Jul 28, 2020

@stachu2k On which platform?

@stachu2k
Copy link

stachu2k commented Jul 28, 2020 •
edited
Loading

@guyca On Android, I have Xiaomi Redmi Note 5 with Android 9. Setting fontSize property to any number value makes the text on right button incredibly small.

picture

@guyca guyca self-assigned this Jul 29, 2020
guyca added a commit that referenced this issue Jul 29, 2020
@guyca
Set TopBar button text in dp instead of pixels
7b732f0 
TopBar button text broke in 6.5.0 and instead of being applied in sp it was applied in pixels. This made if seem like the fontSize option didn't work. This commit fixes the problem and also sets button fontSize in dp so it won't increase too much if users change font size settings in their device.
closes #6405
@guyca guyca mentioned this issue Jul 29, 2020
Merged
yogevbd pushed a commit that referenced this issue Jul 30, 2020
@guyca
Set button text in dp (#6443)
8d1309f 
TopBar button text broke in 6.5.0 and instead of being applied in sp it was applied in pixels. This made if seem like the fontSize option didn't work. This commit fixes the problem and also sets button fontSize in dp so it won't increase too much if users change font size settings in their device.

closes #6405
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guyca guyca

Labels
platform: Android type: accepted/bug type: documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set button text in dp wix/react-native-navigation
3 participants
@oferRounds @stachu2k @guyca