Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V3.4] Set bottom tabs visible affects custom top bar #5628

Closed
blueberry6401 opened this issue Nov 5, 2019 · 0 comments · Fixed by #5634
Closed

[V3.4] Set bottom tabs visible affects custom top bar #5628

blueberry6401 opened this issue Nov 5, 2019 · 0 comments · Fixed by #5634

Comments

@blueberry6401
Copy link

Issue Description

Set bottom tabs visible affects custom component top bar.

Steps to Reproduce / Code Snippets / Screenshots

Example:

  1. I have custom top bar
Navigation.mergeOptions(this, {
    topBar: {
      title: {
        component: {
          name: Screens.ReactTitleView,
          alignment: 'center',
          passProps: {
            text: 'Press Me'
          }
        }
      }
    }
});
  1. Hide bottom tabs
Navigation.mergeOptions(this, {
      bottomTabs: {
        visible: false
      }
    })

The top bar component disappear, it will show the default top bar or empty if you're not set.

Environment

  • React Native Navigation version: 3.4
  • React Native version: 0.61.4
  • Platform(s) (iOS, Android, or both?): iOS
  • Device info (Simulator/Device? OS version? Debug/Release?): All, iOS 13.2
@guyca guyca self-assigned this Nov 6, 2019
guyca added a commit that referenced this issue Nov 7, 2019
When mergeOptions was called without a title component, existing component was undesirably removed.
This commit changes how component is removed when mergeOptions is called. It will now be removed if a component is not defined and title is defined in mergeOptions.
Fixes #5628
guyca added a commit that referenced this issue Nov 7, 2019
When mergeOptions was called without a title component, existing component was undesirably removed.
This commit changes how component is removed when mergeOptions is called. It will now be removed if a component is not defined and title is defined in mergeOptions.
Fixes #5628
vshkl pushed a commit to vshkl/react-native-navigation that referenced this issue Feb 5, 2020
When mergeOptions was called without a title component, existing component was undesirably removed.
This commit changes how component is removed when mergeOptions is called. It will now be removed if a component is not defined and title is defined in mergeOptions.
Fixes wix#5628
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants