Bottom bar visibility Android Fix (#7389)

* demo

* add test to check onViewWillAppear called

* show bottomNavigation when restore without animation

* add onViewWillAppear when tab selected to apply options

* Update app.ts

* Update Options.ts

* Update OptionsScreen.tsx

lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/bottomtabs/BottomTabsController.java

@@ -274,6 +274,7 @@ private void selectTab(int newIndex, boolean enableSelectionHistory) {
         getCurrentView().setVisibility(View.INVISIBLE);
         bottomTabs.setCurrentItem(newIndex, false);
         getCurrentView().setVisibility(View.VISIBLE);
+        getCurrentChild().onViewWillAppear();
         getCurrentChild().onViewDidAppear();
     }
 

lib/android/app/src/main/java/com/reactnativenavigation/views/bottomtabs/BottomTabs.java

@@ -88,6 +88,12 @@ public void setBackgroundColor(int color) {
         if (getDefaultBackgroundColor() != color) setDefaultBackgroundColor(color);
     }
 
+    @Override
+    public void restoreBottomNavigation(boolean withAnimation) {
+        super.restoreBottomNavigation(withAnimation);
+        if (!withAnimation) setVisibility(View.VISIBLE);
+    }
+
     @Override
     public void hideBottomNavigation(boolean withAnimation) {
         super.hideBottomNavigation(withAnimation);

lib/android/app/src/test/java/com/reactnativenavigation/viewcontrollers/bottomtabs/BottomTabsControllerTest.kt

@@ -316,7 +316,24 @@ class BottomTabsControllerTest : BaseTest() {
             ), ArgumentMatchers.any(Int::class.java)
         )
     }
+    @Test
+    fun `mergeOptions - select tab calls onViewWillAppear to apply options on the selected child`(){
+        uut.ensureViewIsCreated()
+        Java6Assertions.assertThat(uut.selectedIndex).isZero
+
+        val options = Options()
+        options.bottomTabsOptions.currentTabIndex = Number(1)
+        uut.mergeOptions(options)
+        Java6Assertions.assertThat(uut.selectedIndex).isOne
+        Mockito.verify(child2).onViewWillAppear()
+        Mockito.verify(child2).onViewDidAppear()
 
+        options.bottomTabsOptions.currentTabIndex = Number(0)
+        uut.mergeOptions(options)
+        Java6Assertions.assertThat(uut.selectedIndex).isZero
+        Mockito.verify(child1).onViewWillAppear()
+        Mockito.verify(child1).onViewDidAppear()
+    }
     @Test
     fun mergeOptions_drawBehind() {
         Java6Assertions.assertThat(uut.getBottomInset(child1)).isEqualTo(uut.bottomTabs.height)

package.json

@@ -216,4 +216,4 @@
       }
     }
   }
-}
+}

playground/src/screens/LayoutsScreen.tsx

@@ -43,6 +43,9 @@ export default class LayoutsScreen extends NavigationComponent<NavigationCompone
 
   static options(): Options {
     return {
+      bottomTabs: {
+        visible: true,
+      },
       topBar: {
         testID: WELCOME_SCREEN_HEADER,
         title: {