Avoid asserting bridge ready on setDefaultOptions (#6374)

There is no need to wait for `JavascriptDidLoad` event on `setDefaultOptions` because all it does is update the default options in the native side.
wix · Jul 8, 2020 · 87e7b1a · 87e7b1a
1 parent 5e03718
commit 87e7b1a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/lib/ios/RNNCommandsHandler.m b/lib/ios/RNNCommandsHandler.m
@@ -102,7 +102,6 @@ - (void)mergeOptions:(NSString*)componentId options:(NSDictionary*)mergeOptions
 }
 
 - (void)setDefaultOptions:(NSDictionary*)optionsDict completion:(RNNTransitionCompletionBlock)completion {
-	[self assertReady];
     RNNAssertMainQueue();
 
 	RNNNavigationOptions* defaultOptions = [[RNNNavigationOptions alloc] initWithDict:optionsDict];

diff --git a/playground/android/build.gradle b/playground/android/build.gradle
@@ -24,8 +24,8 @@ buildscript {
 
 allprojects {
     repositories {
-        maven { url 'https://www.jitpack.io' }
         jcenter()
+        maven { url 'https://www.jitpack.io' }
         google()
         maven {
             // All of React Native (JS, Obj-C sources, Android binaries) is installed from npm

diff --git a/playground/ios/NavigationTests/RNNCommandsHandlerTest.m b/playground/ios/NavigationTests/RNNCommandsHandlerTest.m
@@ -98,6 +98,7 @@ - (NSArray*)getPublicMethodNamesForObject:(NSObject*)obj {
 	[skipMethods addObject:@"dismissedModal:"];
 	[skipMethods addObject:@"attemptedToDismissModal:"];
 	[skipMethods addObject:@"dismissedMultipleModals:"];
+	[skipMethods addObject:@"setDefaultOptions:completion:"];
 
 	NSMutableArray* result = [NSMutableArray new];
 
@@ -503,4 +504,9 @@ - (void)testPop_shouldRejectPromiseForInvalidComponentId {
 	[self waitForExpectationsWithTimeout:5 handler:nil];
 }
 
+- (void)testSetDefaultOptions_shouldNotThrowWhenBridgeNotReady {
+	[self.uut setReadyToReceiveCommands:false];
+	[self.uut setDefaultOptions:@{} completion:^{}];
+}
+
 @end