Skip to content

Commit

Permalink
Fix white topBar on pop with swipe gesture (#6069)
Browse files Browse the repository at this point in the history
This commit fix topBar background wrong color when swiping pop gesture on iOS 13 and above.

Addresses #6055
  • Loading branch information
yogevbd authored Mar 24, 2020
1 parent b0e8a82 commit 6227321
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lib/ios/TopBarAppearancePresenter.m
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ - (void)applyOptions:(RNNTopBarOptions *)options {
}

- (void)applyOptionsBeforePopping:(RNNTopBarOptions *)options {
[self setBackgroundColor:[options.background.color getWithDefaultValue:nil]];

}

- (void)setTranslucent:(BOOL)translucent {
Expand Down
2 changes: 1 addition & 1 deletion playground/ios/NavigationTests/RNNStackPresenterTest.m
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ - (void)testApplyOptionsBeforePoppingShouldSetTopBarBackgroundForPoppingViewCont
_options.topBar.background.color = [[Color alloc] initWithValue:[UIColor redColor]];

[self.uut applyOptionsBeforePopping:self.options];
XCTAssertTrue([_boundViewController.childViewControllers.lastObject.navigationItem.standardAppearance.backgroundColor isEqual:[UIColor redColor]]);
XCTAssertFalse([_boundViewController.childViewControllers.lastObject.navigationItem.standardAppearance.backgroundColor isEqual:[UIColor redColor]]);
}

- (void)testApplyOptionsShouldSetLargeTitleVisible {
Expand Down

0 comments on commit 6227321

Please sign in to comment.