Rename internal getConstants method to prevent conflicts with RN's ge…

…tConstants method (#5745) Related to #4861
wix · Dec 8, 2019 · 5e6d6fc · 5e6d6fc
1 parent 2bde14d
commit 5e6d6fc
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/lib/android/app/src/main/java/com/reactnativenavigation/react/NavigationModule.java b/lib/android/app/src/main/java/com/reactnativenavigation/react/NavigationModule.java
@@ -79,7 +79,7 @@ public void getLaunchArgs(String commandId, Promise promise) {
     }
 
     @ReactMethod
-    public void getConstants(Promise promise) {
+    public void getNavigationConstants(Promise promise) {
         ReactApplicationContext ctx = getReactApplicationContext();
         WritableMap constants = Arguments.createMap();
         constants.putString(Constants.BACK_BUTTON_JS_KEY, Constants.BACK_BUTTON_ID);

diff --git a/lib/ios/RNNBridgeModule.m b/lib/ios/RNNBridgeModule.m
@@ -102,7 +102,7 @@ -(instancetype)initWithCommandsHandler:(RNNCommandsHandler *)commandsHandler {
 	resolve(args);
 }
 
-RCT_EXPORT_METHOD(getConstants:(RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseRejectBlock)reject) {
+RCT_EXPORT_METHOD(getNavigationConstants:(RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseRejectBlock)reject) {
 	resolve([Constants getConstants]);
 }
 

diff --git a/lib/src/adapters/Constants.ts b/lib/src/adapters/Constants.ts
@@ -9,7 +9,7 @@ export interface NavigationConstants {
 
 export class Constants {
   static async get(): Promise<NavigationConstants> {
-    const constants: NavigationConstants = await NativeModules.RNNBridgeModule.getConstants();
+    const constants: NavigationConstants = await NativeModules.RNNBridgeModule.getNavigationConstants();
     return new Constants(constants);
   }