Fix statusBar visibility through mergeOptions (#6437)

`mergeOptions` with `statusBar.visible` didn't work on iOS. This PR fix it.
wix · Jul 27, 2020 · 36e0e81 · 36e0e81
1 parent c9e5309
commit 36e0e81
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/lib/ios/RNNBasePresenter.m b/lib/ios/RNNBasePresenter.m
@@ -72,6 +72,10 @@ - (void)mergeOptions:(RNNNavigationOptions *)options resolvedOptions:(RNNNavigat
 	if (options.window.backgroundColor.hasValue) {
 		UIApplication.sharedApplication.delegate.window.backgroundColor = withDefault.window.backgroundColor.get;
 	}
+
+    if (options.statusBar.visible.hasValue) {
+        [self.boundViewController setNeedsStatusBarAppearanceUpdate];
+    }
 }
 
 - (void)renderComponents:(RNNNavigationOptions *)options perform:(RNNReactViewReadyCompletionBlock)readyBlock {

diff --git a/playground/ios/NavigationTests/RNNBasePresenterTest.m b/playground/ios/NavigationTests/RNNBasePresenterTest.m
@@ -123,4 +123,13 @@ - (void)testHidesBottomBarWhenPushed_resolveChildHidesBarBeforeParent {
 	XCTAssertTrue(_boundViewController.hidesBottomBarWhenPushed);
 }
 
+- (void)testMergeOptions_updatesStatusBarVisibility {
+	RNNNavigationOptions* mergeOptions = [RNNNavigationOptions emptyOptions];
+	mergeOptions.statusBar.visible = [Bool withValue:@(0)];
+
+	[[self.mockBoundViewController expect] setNeedsStatusBarAppearanceUpdate];
+	[self.uut mergeOptions:mergeOptions resolvedOptions:nil];
+	[self.mockBoundViewController verify];
+}
+
 @end