fix: attachment fs operations (#43)

src/runtime/attachment-handlers/moveHandler.ts

@@ -1,13 +1,10 @@
-import path from 'node:path';
-import fs from 'node:fs/promises';
-
 import type { FileAttachmentHandler } from '../types';
+import { fastMove } from '../../utils';
 
 import { placeAttachment } from './placeAttachment';
 
 export const moveHandler: FileAttachmentHandler = async (context) => {
   const destination = placeAttachment(context);
-  await fs.mkdir(path.dirname(destination), { recursive: true });
-  await fs.rename(context.sourcePath, destination);
+  await fastMove(context.sourcePath, destination);
   return destination;
 };

src/runtime/attachment-handlers/placeAttachment.ts

@@ -2,9 +2,10 @@ import path from 'node:path';
 import { randomUUID } from 'node:crypto';
 
 import type { AttachmentContext, ContentAttachmentContext, FileAttachmentContext } from '../types';
+import { getFullExtension } from '../../utils';
 
 export function placeAttachment(context: AttachmentContext): string {
   const { outDir, name, sourcePath } = context as FileAttachmentContext & ContentAttachmentContext;
   const fileName = name || sourcePath || '';
-  return path.join(outDir, randomUUID() + path.extname(fileName));
+  return path.join(outDir, randomUUID() + getFullExtension(fileName));
 }

src/utils/fastMove.test.ts

@@ -0,0 +1,55 @@
+import os from 'node:os';
+import path from 'node:path';
+import fs from 'node:fs/promises';
+
+import { fastMove } from './fastMove';
+
+describe('fastMove', () => {
+  let rootDirectory: string;
+  let source: string;
+  let destination: string;
+
+  beforeEach(() => {
+    jest.spyOn(fs, 'copyFile');
+    jest.spyOn(fs, 'rm');
+  });
+
+  afterEach(() => {
+    jest.restoreAllMocks();
+  });
+
+  beforeEach(async () => {
+    rootDirectory = await fs.mkdtemp(path.join(os.tmpdir(), 'fastmove-'));
+    source = path.join(rootDirectory, 'source.txt');
+    destination = path.join(rootDirectory, 'destination.txt');
+    await fs.writeFile(source, 'Test content');
+  });
+
+  afterEach(async () => {
+    await fs.rm(rootDirectory, { recursive: true });
+  });
+
+  it('should move the file to the destination', async () => {
+    await fastMove(source, destination);
+
+    const movedFile = await fs.readFile(destination, 'utf8');
+    expect(movedFile).toBe('Test content');
+    await expect(fs.access(source)).rejects.toThrow();
+    expect(fs.copyFile).not.toHaveBeenCalled();
+    expect(fs.rm).not.toHaveBeenCalled();
+  });
+
+  it('should handle cross-device file movement', async () => {
+    jest
+      .spyOn(fs, 'rename')
+      .mockRejectedValueOnce({ code: 'EXDEV', message: 'cross-device link not permitted' });
+
+    await fastMove(source, destination);
+
+    const movedFile = await fs.readFile(destination, 'utf8');
+    expect(movedFile).toBe('Test content');
+    await expect(fs.access(source)).rejects.toThrow();
+    expect(fs.copyFile).toHaveBeenCalled();
+    expect(fs.rm).toHaveBeenCalled();
+  });
+});

src/utils/fastMove.ts

@@ -0,0 +1,13 @@
+import path from 'node:path';
+import fs from 'node:fs/promises';
+
+export async function fastMove(source: string, destination: string) {
+  await fs.mkdir(path.dirname(destination), { recursive: true });
+
+  try {
+    await fs.rename(source, destination);
+  } catch {
+    await fs.copyFile(source, destination);
+    await fs.rm(source, { force: true });
+  }
+}

src/utils/getFullExtension.test.ts

@@ -0,0 +1,33 @@
+import { getFullExtension } from './getFullExtension';
+
+describe('getFullExtension', () => {
+  it('should return the full extension for a file with multiple dots', () => {
+    const filePath = 'example.viewhierarchy.zip';
+    const extension = getFullExtension(filePath);
+    expect(extension).toBe('.viewhierarchy.zip');
+  });
+
+  it('should return the extension for a file with a single dot', () => {
+    const filePath = 'example.txt';
+    const extension = getFullExtension(filePath);
+    expect(extension).toBe('.txt');
+  });
+
+  it('should return the extension for a file starting with a dot', () => {
+    const filePath = '.gitignore';
+    const extension = getFullExtension(filePath);
+    expect(extension).toBe('.gitignore');
+  });
+
+  it('should return an empty string for a file without an extension', () => {
+    const filePath = 'example';
+    const extension = getFullExtension(filePath);
+    expect(extension).toBe('');
+  });
+
+  it('should return an empty string for empty or dot paths', () => {
+    expect(getFullExtension('')).toBe('');
+    expect(getFullExtension('.')).toBe('');
+    expect(getFullExtension('..')).toBe('');
+  });
+});

src/utils/getFullExtension.ts

@@ -0,0 +1,10 @@
+import path from 'node:path';
+
+export function getFullExtension(filePath: string) {
+  if (!filePath || filePath === '.' || filePath === '..') return '';
+
+  const fileName = path.basename(filePath);
+  const lastDotIndex = fileName.indexOf('.');
+
+  return lastDotIndex === -1 ? '' : fileName.slice(lastDotIndex);
+}

src/utils/index.ts

@@ -3,7 +3,9 @@ export * from './asArray';
 export * from './asMaybeArray';
 export * from './autoIndent';
 export * from './compactObject';
+export * from './fastMove';
 export * from './FileNavigator';
+export * from './getFullExtension';
 export * from './getStatusDetails';
 export * from './hijackFunction';
 export * from './importFrom';