Stabilize inline stylesheets #7180
Merged
+61
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c2af343 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
matthewp
reviewed
May 23, 2023
| @@ -0,0 +1,24 @@ | |||
| --- | |||
| 'astro': major | |||
There was a problem hiding this comment.
We probably won't release a major for another couple of months, we're going to time it with the next Vite major.
So for now I think this should be a minor and continue to have never as the default. In 3.0 we can switch to auto.
There was a problem hiding this comment.
You're right, I forgot what major means.
matthewp
previously requested changes
May 23, 2023
sarah11918
approved these changes
May 29, 2023
lilnasy
force-pushed
the
stabilize-inline-stylesheets
branch
from
4f336e5
to
7de8901
Compare
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
lilnasy
force-pushed
the
stabilize-inline-stylesheets
branch
from
7de8901
to
c2af343
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Stabilize
AstroConfig.build.inlineStylesheets.Testing
Existing ones should pass.
Docs
I think Configuration reference as-is would be sufficient.