Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #6420 #6544

Merged
merged 20 commits into from
Apr 12, 2023
Merged

fix #6420 #6544

merged 20 commits into from
Apr 12, 2023

Conversation

JerryWu1234
Copy link
Contributor

Changes

fix #6420
It can't find this file cause the node throws an error if the users custom a path that includes the folder path

Testing

Docs

@changeset-bot
Copy link

changeset-bot bot commented Mar 14, 2023

🦋 Changeset detected

Latest commit: e98b3a9

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Mar 14, 2023
@JerryWu1234
Copy link
Contributor Author

image
I try a different version of the nodejs. But there is nothing on my computer.

@JerryWu1234 JerryWu1234 marked this pull request as ready for review March 15, 2023 03:31
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the template under the "Testing" section, and say that you added a new test case

.changeset/moody-points-reflect.md Outdated Show resolved Hide resolved
packages/astro/src/core/build/static-build.ts Outdated Show resolved Hide resolved
@matthewp matthewp merged commit a9c2299 into withastro:main Apr 12, 2023
@astrobot-houston astrobot-houston mentioned this pull request Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node and Rollup assetFileNames output to wrong path
3 participants