Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Svelte README #5923

Merged
merged 4 commits into from
Jan 21, 2023
Merged

Improve Svelte README #5923

merged 4 commits into from
Jan 21, 2023

Conversation

delucis
Copy link
Member

@delucis delucis commented Jan 21, 2023

Changes

  • Fixes up a few details that weren’t quite clear in the Svelte README

Testing

n/a

Docs

cc @withastro/maintainers-docs for feedback!

@delucis delucis requested a review from a team as a code owner January 21, 2023 01:25
@changeset-bot
Copy link

changeset-bot bot commented Jan 21, 2023

🦋 Changeset detected

Latest commit: 046006b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@delucis delucis self-assigned this Jan 21, 2023
@github-actions github-actions bot added pkg: svelte Related to Svelte (scope) pkg: integration Related to any renderer integration (scope) labels Jan 21, 2023
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there was just a word ommitted, otherwise, LGTM! Thank you for this, @delucis! 🙌

delucis and others added 2 commits January 21, 2023 10:47
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@delucis delucis merged commit f32bf07 into main Jan 21, 2023
@delucis delucis deleted the chris/svelte-readme branch January 21, 2023 09:55
matthewp pushed a commit that referenced this pull request Jan 26, 2023
* First stylistic pass

* Rework for x/o instead of and

* fix typo

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

* Add changeset

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope) pkg: svelte Related to Svelte (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants