Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add response iterator to node adapter #5418

Merged
merged 4 commits into from
Nov 16, 2022

Conversation

jbanety
Copy link
Contributor

@jbanety jbanety commented Nov 16, 2022

Changes

Sometimes Astro sends a ReadableStream or a Buffer as a response body and it raise an error TypeError: body is not async iterable.
I added a function to get a response iterator from different response types (sourced from apollo-client).
With this, node adapter can handle all the Astro response types.

Testing

Not implemented. I tested this in my project.

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Nov 16, 2022

🦋 Changeset detected

Latest commit: be87f76

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Nov 16, 2022
@jbanety jbanety changed the title Response iterator Add response iterator to node adapter Nov 16, 2022
Copy link
Contributor

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@matthewp matthewp merged commit aa16b6c into withastro:main Nov 16, 2022
This was referenced Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants