Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark @astrojs/node to be noExternal #5114

Merged
merged 2 commits into from
Oct 18, 2022
Merged

Mark @astrojs/node to be noExternal #5114

merged 2 commits into from
Oct 18, 2022

Conversation

matthewp
Copy link
Contributor

Changes

Testing

  • Tests already worked within the monorepo, because the monorepo does not allow actual node_modules/ folders which is where the bug occured.
  • Tested with the example in the issue.

Docs

N/A, bug fix

@changeset-bot
Copy link

changeset-bot bot commented Oct 18, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: acc879c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Oct 18, 2022
@matthewp matthewp merged commit 5c0c6e1 into main Oct 18, 2022
@matthewp matthewp deleted the node-standalone-static branch October 18, 2022 15:47
@astrobot-houston astrobot-houston mentioned this pull request Oct 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node standalone server does not serve assets (unless you run astro preview)
2 participants
@matthewp @bluwy