Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix astro add adding lines from extended configurations #5095

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

Princesseuh
Copy link
Member

Changes

astro add was mistakenly merging the full extended configuration instead of just the found one, this fix that. Additionally, the react-dom types were missing so I went ahead and added that

Testing

Tested manually

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Oct 14, 2022

🦋 Changeset detected

Latest commit: 33c37b5

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: react Related to React (scope) pkg: integration Related to any renderer integration (scope) labels Oct 14, 2022
@Princesseuh Princesseuh self-assigned this Oct 14, 2022
@Princesseuh Princesseuh merged commit ddfbef5 into main Oct 14, 2022
@Princesseuh Princesseuh deleted the fix-astro-add-extends branch October 14, 2022 18:16
@astrobot-houston astrobot-houston mentioned this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: react Related to React (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants