Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes JSX usage of slots with dashes in their name #5080

Merged
merged 3 commits into from
Oct 13, 2022
Merged

Conversation

matthewp
Copy link
Contributor

Changes

Testing

  • Added JSX test. Verifies both when there are an array of children and when there is just a single vnode.

Docs

N/A, bug fix

@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2022

🦋 Changeset detected

Latest commit: 85f1a09

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Oct 13, 2022
@withastro withastro deleted a comment from github-actions bot Oct 13, 2022
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense. The dash-case to camelCase conversion was meant to match the behavior of our renderers, but the conversion happens on the renderer level so this is not needed here (and is unexpected for Astro/Vue/Svelte components)

@matthewp matthewp merged commit 90b715d into main Oct 13, 2022
@matthewp matthewp deleted the jsx-slash-slot branch October 13, 2022 21:40
@astrobot-houston astrobot-houston mentioned this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Named slots do not work in MDX sometimes
2 participants