Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue] add support for appEntrypoint #5075

Merged
merged 5 commits into from
Oct 13, 2022
Merged

[Vue] add support for appEntrypoint #5075

merged 5 commits into from
Oct 13, 2022

Conversation

natemoo-re
Copy link
Member

Changes

  • Adds support for appEntrypoint option in @astrojs/vue integration
  • appEntrypoint is a root-relative import specifier to the app entrypoint file
  • appEntrypoint should export a default isomorphic function that receives a Vue app instance. The return type is void | Promise<void>.
  • This exposes Vue Plugins to users!

Testing

Tests added to Vue integration directly

Docs

TODO

@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2022

🦋 Changeset detected

Latest commit: b47e657

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: vue Related to Vue (scope) pkg: integration Related to any renderer integration (scope) labels Oct 13, 2022
@natemoo-re natemoo-re requested a review from a team as a code owner October 13, 2022 17:56
@natemoo-re
Copy link
Member Author

!preview app-entrypoint

@github-actions
Copy link
Contributor

 > root@0.0.0 release /home/runner/work/astro/astro > pnpm run build && changeset publish "--tag" "next--app-entrypoint" > root@0.0.0 build /home/runner/work/astro/astro > turbo run build --output-logs=new-only --no-deps --filter=astro --filter=create-astro --filter="@astrojs/*" �[2m• Packages in scope: @astrojs/alpinejs, @astrojs/cloudflare, @astrojs/deno, @astrojs/image, @astrojs/lit, @astrojs/markdown-component, @astrojs/markdown-remark, @astrojs/mdx, @astrojs/netlify, @astrojs/node, @astrojs/partytown, @astrojs/preact, @astrojs/prefetch, @astrojs/prism, @astrojs/react, @astrojs/rss, @astrojs/sitemap, @astrojs/solid-js, @astrojs/svelte, @astrojs/tailwind, @astrojs/telemetry, @astrojs/turbolinks, @astrojs/vercel, @astrojs/vue, @astrojs/webapi, astro, create-astro�[0m �[2m• Running�[0m �[2m�[1mbuild�[0m�[0m �[2min 27 packages�[0m �[2m• Remote computation caching enabled (experimental)�[0m �[35m@astrojs/webapi:build: �[0mcache hit, suppressing output �[2mf9476e5b3ac7bbae�[0m �[33m@astrojs/telemetry:build: �[0mcache hit, suppressing output �[2m5625f8c29bb635e6�[0m �[34mcreate-astro:build: �[0mcache hit, suppressing output �[2m2eac49a7d0d7c02b�[0m �[36m@astrojs/prism:build: �[0mcache hit, suppressing output �[2mce2800daeec144c3�[0m �[35m@astrojs/markdown-remark:build: �[0mcache hit, suppressing output �[2m489fff4e2595ca1e�[0m �[32mastro:build: �[0mcache hit, suppressing output �[2mfc3c9bf2f234fa2e�[0m �[33m@astrojs/tailwind:build: �[0mcache hit, suppressing output �[2m64d4868037d75539�[0m �[36m@astrojs/turbolinks:build: �[0mcache hit, suppressing output �[2meef7926a19dc06bc�[0m �[34m@astrojs/solid-js:build: �[0mcache hit, suppressing output �[2m628d8bd6e33d8c40�[0m �[35m@astrojs/node:build: �[0mcache hit, suppressing output �[2mb8472830f8c94908�[0m �[32m@astrojs/mdx:build: �[0mcache hit, suppressing output �[2md7d4df736980f8d7�[0m �[34m@astrojs/react:build: �[0mcache hit, suppressing output �[2m1538599040cd312a�[0m �[33m@astrojs/partytown:build: �[0mcache hit, suppressing output �[2mb8e899149d132f60�[0m �[36m@astrojs/alpinejs:build: �[0mcache hit, suppressing output �[2mc3b28d5e8e8a4cb4�[0m �[35m@astrojs/deno:build: �[0mcache hit, suppressing output �[2mb16de391828b9aaa�[0m �[32m@astrojs/rss:build: �[0mcache hit, suppressing output �[2m860eefdb6d8ee33b�[0m �[33m@astrojs/svelte:build: �[0mcache hit, suppressing output �[2mfbac7c077cdc26d5�[0m �[32m@astrojs/prefetch:build: �[0mcache hit, suppressing output �[2m37febd8b44e4e60a�[0m �[36m@astrojs/netlify:build: �[0mcache hit, suppressing output �[2mfb846cf144054635�[0m �[34m@astrojs/sitemap:build: �[0mcache hit, suppressing output �[2m63898a84c35b50f2�[0m �[35m@astrojs/cloudflare:build: �[0mcache hit, suppressing output �[2mae2868efe4bacb20�[0m �[32m@astrojs/vercel:build: �[0mcache hit, suppressing output �[2md0a30ac8026fed37�[0m �[34m@astrojs/preact:build: �[0mcache hit, suppressing output �[2mac250c55cec93c7c�[0m �[36m@astrojs/lit:build: �[0mcache hit, suppressing output �[2m6888f6eff79660b4�[0m �[35m@astrojs/image:build: �[0mcache hit, suppressing output �[2m86afb9477115ddcc�[0m �[33m@astrojs/vue:build: �[0mcache miss, executing �[2m54138d5f391813da�[0m �[33m@astrojs/vue:build: �[0m �[33m@astrojs/vue:build: �[0m> @astrojs/vue@0.0.0-app-entrypoint-20221013181129 build /home/runner/work/astro/astro/packages/integrations/vue �[33m@astrojs/vue:build: �[0m> astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc �[33m@astrojs/vue:build: �[0m Tasks: 26 successful, 26 total Cached: 25 cached, 26 total Time: 4.232s 🦋 �[33mwarn�[39m �[31m===============================IMPORTANT!===============================�[39m 🦋 �[33mwarn�[39m Packages will be released under the next--app-entrypoint tag 🦋 �[33mwarn�[39m �[31m----------------------------------------------------------------------�[39m 🦋 �[36minfo�[39m npm info astro 🦋 �[36minfo�[39m npm info @astrojs/prism 🦋 �[36minfo�[39m npm info @astrojs/rss 🦋 �[36minfo�[39m npm info create-astro 🦋 �[36minfo�[39m npm info @astrojs/alpinejs 🦋 �[36minfo�[39m npm info @astrojs/cloudflare 🦋 �[36minfo�[39m npm info @astrojs/deno 🦋 �[36minfo�[39m npm info @astrojs/image 🦋 �[36minfo�[39m npm info @astrojs/lit 🦋 �[36minfo�[39m npm info @astrojs/mdx 🦋 �[36minfo�[39m npm info @astrojs/netlify 🦋 �[36minfo�[39m npm info @astrojs/node 🦋 �[36minfo�[39m npm info @astrojs/partytown 🦋 �[36minfo�[39m npm info @astrojs/preact 🦋 �[36minfo�[39m npm info @astrojs/prefetch 🦋 �[36minfo�[39m npm info @astrojs/react 🦋 �[36minfo�[39m npm info @astrojs/sitemap 🦋 �[36minfo�[39m npm info @astrojs/solid-js 🦋 �[36minfo�[39m npm info @astrojs/svelte 🦋 �[36minfo�[39m npm info @astrojs/tailwind 🦋 �[36minfo�[39m npm info @astrojs/turbolinks 🦋 �[36minfo�[39m npm info @astrojs/vercel 🦋 �[36minfo�[39m npm info @astrojs/vue 🦋 �[36minfo�[39m npm info @astrojs/markdown-component 🦋 �[36minfo�[39m npm info @astrojs/markdown-remark 🦋 �[36minfo�[39m npm info @astrojs/telemetry 🦋 �[36minfo�[39m npm info @astrojs/webapi 🦋 �[33mwarn�[39m astro is not being published because version 1.5.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/prism is not being published because version 1.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/rss is not being published because version 1.0.2 is already published on npm 🦋 �[33mwarn�[39m create-astro is not being published because version 1.1.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/alpinejs is not being published because version 0.1.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/cloudflare is not being published because version 3.1.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/deno is not being published because version 1.2.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/image is not being published because version 0.10.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/lit is not being published because version 1.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/mdx is not being published because version 0.11.4 is already published on npm 🦋 �[33mwarn�[39m @astrojs/netlify is not being published because version 1.2.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/node is not being published because version 2.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/partytown is not being published because version 1.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/preact is not being published because version 1.2.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/prefetch is not being published because version 0.0.8 is already published on npm 🦋 �[33mwarn�[39m @astrojs/react is not being published because version 1.2.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/sitemap is not being published because version 1.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/solid-js is not being published because version 1.2.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/svelte is not being published because version 1.0.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/tailwind is not being published because version 2.1.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/turbolinks is not being published because version 0.1.4 is already published on npm 🦋 �[33mwarn�[39m @astrojs/vercel is not being published because version 2.2.0 is already published on npm 🦋 �[36minfo�[39m @astrojs/vue is being published because our local version (0.0.0-app-entrypoint-20221013181129) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/markdown-component is not being published because version 1.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/markdown-remark is not being published because version 1.1.3 is already published on npm 🦋 �[33mwarn�[39m @astrojs/telemetry is not being published because version 1.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/webapi is not being published because version 1.1.0 is already published on npm 🦋 �[36minfo�[39m Publishing �[36m"@astrojs/vue"�[39m at �[32m"0.0.0-app-entrypoint-20221013181129"�[39m 🦋 �[32msuccess�[39m packages published successfully: 🦋 @astrojs/vue@0.0.0-app-entrypoint-20221013181129 🦋 Creating git tag... 🦋 New tag: @astrojs/vue@0.0.0-app-entrypoint-20221013181129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope) pkg: vue Related to Vue (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants