adding cookies to api route response [simple result] #5060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 79bb937 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
matthewp
reviewed
Oct 12, 2022
|
Looks good overall! Just one thing about how the cookies are set in dev. Love the example update to use Astro.cookies as well! |
AirBorne04
commented
Oct 14, 2022
Comment on lines
-426
to
+388
| res.writeHead(200, { 'Content-Type': `${contentType};charset=utf-8` }); | ||
| res.end(result.body); | ||
| const response = new Response(result.body, { | ||
| status: 200, | ||
| headers: { | ||
| 'Content-Type': `${contentType};charset=utf-8`, | ||
| }, | ||
| }); | ||
| attachToResponse(response, result.cookies); | ||
| await writeWebResponse(res, response); |
There was a problem hiding this comment.
I converted the direct writing to the response to a call to writeWebResponse in order to streamline the response handling. Also added a call to attachToResponse in order to connect the cookie to the response.
|
This looks great, thank you! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
simpleobject]simple,Response)ssrto use the build in cookie handling vs lightcookie 3rd partyTesting
ssrfrom the repobuild -> preview with nodeanddevDocs