Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create-astro combine strict tsconfigs #4301

Closed

Conversation

laesse
Copy link

@laesse laesse commented Aug 13, 2022

Changes

fixing #4297

  • merge the tsconfig.json of the template into tsconfig.strict.json instead of overriding it
  • this implementation preserves the comments in the tsconfig
  • Templates that have custom tsconfigs can keep the specific compilerOptions but still have the strict mode options enabled.
  • when the option is present in both the strict option overrides the template option

This leads to less broken strict/strictest templates on project start

Testing

I tested it locally
I have not written any unit tests, jet

Docs

  • no docs added because it is fixing behaviour that is expected in my opinion

@changeset-bot
Copy link

changeset-bot bot commented Aug 13, 2022

🦋 Changeset detected

Latest commit: db84caa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-astro Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: create-astro Related to the `create-astro` package (scope) label Aug 13, 2022
@matthewp
Copy link
Contributor

@laesse can you fix the lint errors? Thank you!

@Princesseuh
Copy link
Member

Hello! Thank you very much for making this PR (and making me discover that npm package, I didn't know that existed!). We're currently aiming toward a different direction to tackle this issue, see #4439, so we'll close this PR in favour of that.

Again, we're really thankful for your work on this and are really glad you choose to contribute to the project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: create-astro Related to the `create-astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants