Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Svelte view transition state persistence #12006

Conversation

johannesspohr
Copy link
Contributor

Changes

This change fixes view transition state persistence for Svelte components. It keeps track of mounted components and updates props instead of remounting the component.

Related to #11854.

Testing

E2E test was added

Docs

This behavior is already documented but was not working until now.

Copy link

changeset-bot bot commented Sep 16, 2024

🦋 Changeset detected

Latest commit: ee50695

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: svelte Related to Svelte (scope) pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) labels Sep 16, 2024
@martrapp martrapp merged commit a582cb6 into withastro:main Sep 17, 2024
13 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: svelte Related to Svelte (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants