Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove experimental.serverIslands flag #11991

Merged
merged 5 commits into from
Sep 13, 2024
Merged

Remove experimental.serverIslands flag #11991

merged 5 commits into from
Sep 13, 2024

Conversation

matthewp
Copy link
Contributor

Changes

  • Previously unflagged, but the actual flag was mistakenly not removed, or came back in a merge conflict, not sure.

Testing

  • Tests should pass

Docs

N/A

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 13, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 4f19ebc

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) docs pr labels Sep 13, 2024
@sarah11918
Copy link
Member

sarah11918 commented Sep 13, 2024 •
edited
Loading

Yup, big ol' delete is perfect! Please also update an error message for the new page (both places the URL exists)

It's around line 418. The new page referenced should be:

[On-demand Rendering](https://5-0-0-beta.docs.astro.build/en/guides/on-demand-rendering/)

In both the @see and the hint

image

@sarah11918
Copy link
Member

Just updated to the beta docs! This is where most things should point for the new beta features until 5.0 is stable. I'll make us all a handy cheat sheet of when to use beta links!

matthewp and others added 2 commits September 13, 2024 12:13
@matthewp @sarah11918
Update packages/astro/src/core/errors/errors-data.ts
6611dbd 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@matthewp @sarah11918
Update packages/astro/src/core/errors/errors-data.ts
4f19ebc 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@matthewp matthewp merged commit d7a396c into next Sep 13, 2024
14 checks passed
@matthewp matthewp deleted the remove-exp-si branch September 13, 2024 16:49
@astrobot-houston astrobot-houston mentioned this pull request Sep 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees
No one assigned
Labels
docs pr pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewp @sarah11918