Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .gitignore #256

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Update .gitignore #256

merged 1 commit into from
Sep 8, 2023

Conversation

amotl
Copy link
Member

@amotl amotl commented Oct 23, 2021

Hi Daniel,

I removed this commit from #254 and hereby handing it in seperately.

With kind regards,
Andreas.


Add two more folders to be ignored.

  • .idea: Used by PyCharm
  • .venv: My convention for creating virtualenvs

Copy link
Collaborator

@kvid kvid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems useful

Add two more folders to be ignored.

- .idea: Used by PyCharm
- .venv: My convention for creating virtualenvs
@amotl amotl merged commit a16f2e4 into wireviz:master Sep 8, 2023
2 checks passed
@amotl amotl deleted the amo/update-ignore branch September 8, 2023 18:49
kvid pushed a commit to kvid/WireViz that referenced this pull request Sep 8, 2023
Add two more folders to be ignored.

- .idea: Used by PyCharm
- .venv: My convention for creating virtualenvs
kvid added a commit to kvid/WireViz that referenced this pull request Sep 8, 2023
@kvid
Copy link
Collaborator

kvid commented Sep 8, 2023

I'm sorry that I approved this without noticing a couple of things that should have been fixed first:

  • PR changes should normally have dev as base branch to collect changes for the next ordinary release, unless it's important to update the master branch before the next ordinary release (like a hotfix release).
  • CHANGELOG.md should be updated with a notice as part of the PR.

As your change doesn't change any code, no big harm is done, and I don't see any reason to create a hotfix release for this commit added to master. However, I've also added your commit plus a notice in CHANGELOG.md to the dev branch.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants