Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getCollisionGroup and setCollisionGroup #2750

Merged
merged 4 commits into from
Sep 19, 2023
Merged

Add getCollisionGroup and setCollisionGroup #2750

merged 4 commits into from
Sep 19, 2023

Conversation

Vurv78
Copy link
Member

@Vurv78 Vurv78 commented Sep 15, 2023 •
edited
Loading

Resolves #2749

RFC

Should this deprecate noCollideAll ?

@Vurv78
Copy link
Member Author

Vurv78 commented Sep 15, 2023 •
edited
Loading

Both lints are caused by the extension preprocessor, funny..

Really need #2555 merged

@Denneisk
Copy link
Member

Denneisk commented Sep 15, 2023 •
edited
Loading

noCollideAll is a bit more intuitive but my concern is people demanding for constraintcore to be enabled just for that function, so it probably should be deprecated just for that (or move noCollideAll out of constraintcore and keep it since it's not really that bad of an alternative).

@Vurv78
Copy link
Member Author

Vurv78 commented Sep 15, 2023 •
edited
Loading

That seems fair, not sure if it should be a part of this PR, though

@Denneisk
Copy link
Member

The way I see it, creating setCollisionGroup and moving noCollideAll are basically the same thing.

@Vurv78 Vurv78 merged commit 9a37581 into wiremod:master Sep 19, 2023
1 check failed
@Vurv78 Vurv78 deleted the setcolgroup branch September 19, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thegrb93 thegrb93 thegrb93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vurv78 @Denneisk @thegrb93