Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme with forceConsole info #2493

Merged
merged 4 commits into from
Aug 8, 2024

Conversation

neilenns
Copy link
Contributor

@neilenns neilenns commented Aug 6, 2024

Adds a section to the readme about the forceConsole flag added in #2276, at the request of @DABH.

Note that I haven't yet tried the new flag so opening as a draft. Will flip this to ready once there's a Winston build out with the new flag that I can test locally to confirm I have the sample code correct.

README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@DABH DABH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM up to comments - thank you!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@DABH
Copy link
Contributor

DABH commented Aug 8, 2024

(P.S., #2276 was released in winston 3.14.0, so we should merge this asap)

@neilenns neilenns marked this pull request as ready for review August 8, 2024 03:45
@neilenns neilenns requested a review from DABH August 8, 2024 03:45
@DABH DABH merged commit b2b79af into winstonjs:master Aug 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants