Zip archives if zippedArchive is true

[pixtron]

As reported in #1128 since v3 the archives are not zipped anymore. They just get the ".gz" file extension.

As @glemco correctly pointed out the gzip stream never get's any data piped into as the log data is directly piped from the passthrough stream to the file:

winston/lib/winston/transports/file.js

Line 553 in 319abf1

source.pipe(dest);

The docs say:

zippedArchive: If true, all log files but the current one will be zipped.

Therefore the data should not be zipped while logging, but when the files are rotated.

The PR contains the following changes and resolves #1128

• Zip archives during rotation if zippedArchive is true
• Remove gzip stream which was never written to
  (see Winston Transport File - zippedArchive option doesn't work correctly #1128 (comment))
• ads tests checking the contents of zipped archives
• ads tests for rolling files with tailable: false
• previously failing test tests/tail.file.test.js now passes

[pixtron]

Tests are running without any errors on local windows with node v8, v10 and v12. Not sure why the test for the last two commit failed on appveyor, but Error: Cannot find module 'C:\projects\winston\node' seems to be a temporary error while starting mocha.

For the first three commits the EPERM was most likely thrown because of nodejs/node/issues/4760. On Windows fs.readdir called shortly after unlinking a file, might report the unlinked file still present until all handles are closed. In this case a call to fs.unlink or fs.lstat on that file errors with EPERM as long as the file is in the transient state of being unlinked.

[bartenew]

Can this be merged?

[kingnebby]

👍

[hfritts]

👍

[n8dickinson]

👍🏼

[jtackett-collinear]

👍

[eric-gonzalez-tfs]

👍🏽

[DABH]

Closing this in favor of #2337, which is essentially the same but no conflicts. Thank you for this contribution (which is mainly incorporated in the other PR -- want to make sure you're getting credit). But I think we can go ahead and try to merge this other PR and see if people are happy with it.