Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if external process is started in java code #995

Merged
merged 18 commits into from
Jun 30, 2023

Conversation

showpune
Copy link
Contributor

Update the windup rule to check if to use Process/ProcessBuilder/ProcessHandle to handle external process

@PhilipCattanach
Copy link
Contributor

@m-brophy - I have created Jira https://issues.redhat.com/browse/WINDUPRULE-1024
I think we might want to chnage the effort on both rules in the ruleset.

@m-brophy
Copy link
Contributor

I've renumbered the tests because by convention we number the tests to match the rule it's testing. I have no idea why the previous test was numbered incorrectly for this one to follow on from.

@m-brophy
Copy link
Contributor

lgtm - when ci tests finish running I'll merge

@m-brophy m-brophy merged commit 2e0ed9b into windup:master Jun 30, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants