Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WINDUPRULE-1008 fix hsearch ruleset broken link #981

Merged
merged 5 commits into from
Jun 5, 2023
Merged

WINDUPRULE-1008 fix hsearch ruleset broken link #981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
73ede26
WINDUPRULE-1008 fix hsearch ruleset broken link
PhilipCattanach Jun 5, 2023
22ae55b
WINDUPRULE-1008 broken link fix
PhilipCattanach Jun 5, 2023
a6ba300
Include windup-rules-yaml to the tests as an addon (#969)
carlosthe19916 Jun 5, 2023
6636386
WINDUPRULE-1008 Add stacktrace printing
mrizzi Jun 5, 2023
ef46b5b
WINDUPRULE-1008 Exclude hsearch-00118 'Lucene native faceting' link f…
mrizzi Jun 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions rules/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,12 @@
<classifier>forge-addon</classifier>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.jboss.windup.rules.apps</groupId>
<artifactId>windup-rules-yaml</artifactId>
<classifier>forge-addon</classifier>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.jboss.windup.reporting</groupId>
<artifactId>windup-reporting-data</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion rules/rules-reviewed/eap7/eap6/hsearch.windup.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,7 +575,7 @@
<link
href="https://access.redhat.com/documentation/en-us/red_hat_jboss_enterprise_application_platform/7.0/html-single/migration_guide/#migrate_miscellaneous_hibernate_search_changes"
title="Miscellaneous Changes in Hibernate Search 5.x" />
<link href="http://in.relation.to/2015/05/11/hibernate-search-530-beta-1-with-native-lucene-faceting" title="Lucene native faceting" />
<link href="https://in.relation.to/2015/05/11/hibernate-search-530-beta-1-with-native-lucene-faceting/" title="Lucene native faceting" />
<link href="http://docs.jboss.org/hibernate/search/5.5/reference/en-US/html_single/#query-faceting" title="Query faceting" />
<tag>hibernate-search</tag>
</hint>
Expand Down
3 changes: 2 additions & 1 deletion rules/src/test/java/org/jboss/windup/rules/tests/WindupRulesLinksTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ public class WindupRulesLinksTest {
private static final List<String> CERT_FAILURE_LINKS = new ArrayList<>();
static {
CERT_FAILURE_LINKS.add("https://oracle.com/technical-resources/articles/java/jaxrs20.html");
CERT_FAILURE_LINKS.add("https://in.relation.to/2015/05/11/hibernate-search-530-beta-1-with-native-lucene-faceting/");
}

@Parameterized.Parameters(name = "{index}: Test {0}")
Expand Down Expand Up @@ -170,7 +171,7 @@ private boolean isValidLink(final String link)
else LOG.error(String.format("Response code %d for %s [%dms]", CACHE_ANALYZED_LINKS.get(link), link, System.currentTimeMillis() - starTime));
return validLink;
} catch (IOException e) {
LOG.error(String.format("'%s' exception connecting to %s", e.getMessage(), link));
LOG.error(String.format("'%s' exception connecting to %s", e.getMessage(), link), e);
return false;
}
}
Expand Down
1 change: 1 addition & 0 deletions rules/src/test/java/org/jboss/windup/rules/tests/WindupRulesMultipleTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ public static Collection<File[]> data(boolean findingTestFiles)
@AddonDependency(name = "org.jboss.windup.rules.apps:windup-rules-java-ee"),
@AddonDependency(name = "org.jboss.windup.rules.apps:windup-rules-java-project"),
@AddonDependency(name = "org.jboss.windup.rules.apps:windup-rules-xml"),
@AddonDependency(name = "org.jboss.windup.rules.apps:windup-rules-yaml"),
@AddonDependency(name = "org.jboss.windup.reporting:windup-reporting"),
@AddonDependency(name = "org.jboss.windup.reporting:windup-reporting-data"),
@AddonDependency(name = "org.jboss.windup.utils:windup-utils"),
Expand Down
1 change: 1 addition & 0 deletions rules/src/test/java/org/jboss/windup/rules/tests/WindupRulesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ public class WindupRulesTest
@AddonDependency(name = "org.jboss.windup.rules.apps:windup-rules-java-ee"),
@AddonDependency(name = "org.jboss.windup.rules.apps:windup-rules-java-project"),
@AddonDependency(name = "org.jboss.windup.rules.apps:windup-rules-xml"),
@AddonDependency(name = "org.jboss.windup.rules.apps:windup-rules-yaml"),
@AddonDependency(name = "org.jboss.windup.reporting:windup-reporting"),
@AddonDependency(name = "org.jboss.windup.reporting:windup-reporting-data"),
@AddonDependency(name = "org.jboss.windup.utils:windup-utils"),
Expand Down