[WINDUPRULE-1005]-JWS: Upgrade direct dependencies that belong to the groupId org.apache.tomcat #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosthe19916
changed the title
|
Hi @carlosthe19916 |
@PhilipCattanach you are right! I've just changed the |
|
The test data folder should have included a couple of 'dummy' tomcat artifacts. One with a version below the threshold and the other above. But I ran that test after building the CLI with the ruleset included. The rule fired against tomcat-catalina-10.0.27.jar but not against tomcat-catalina-10.1.0.jar |
mrizzi
added a commit
that referenced
this pull request
Jun 8, 2023
* Lombok <1.18.22 is not compatible with JDK 17 * Overriding rules * [WINDUPRULE-1005]-JWS: Upgrade direct dependencies that belong to the groupId org.apache.tomcat (#972) * Add tomcat target and dependencies rule * Add Tomcat direct dependency check rules * Change toVersion * check java version for azure (#957) * check java version for azure * Azure java version identification * use winup:matches --------- Co-authored-by: kaiqianyang <kaiqianyang@microsoftcom> Co-authored-by: PhilipCattanach <pcattana@redhat.com> * Enabled 'rules-overridden-azure' testing on GH --------- Co-authored-by: Carlos E. Feria Vila <carlosthe19916@gmail.com> Co-authored-by: KaiqianYang <89442934+KaiqianYang@users.noreply.github.com> Co-authored-by: kaiqianyang <kaiqianyang@microsoftcom> Co-authored-by: PhilipCattanach <pcattana@redhat.com> Co-authored-by: mrizzi <mrizzi@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/WINDUPRULE-1005
Tomcat direct dependency upgrade rules