Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make rule spring boot rule available for spring apps #918

Merged
merged 6 commits into from
Apr 12, 2023
Merged

Make rule spring boot rule available for spring apps #918

merged 6 commits into from
Apr 12, 2023

Conversation

showpune
Copy link
Contributor

  1. Make rule spring boot rule azure target to azure spring apps
  2. Update the doc link to azure spring apps

@agoncal
Copy link
Contributor

agoncal commented Apr 10, 2023

@showpune looks good to me. But you should internationalize the documentation links removing the specific en-us. So instead of https://learn.microsoft.com/en-us consider just having https://learn.microsoft.com.

If you want the Azure Spring Apps target to appear in the Web Console, you should add it here:

https://github.com/windup/windup-web/blob/master/ui-pf4/src/main/webapp/src/layout/TransformationPaths.ts#L117

@showpune
Copy link
Contributor Author

Thanks @agoncal for reminder

  1. The link is changed from https://learn.microsoft.com/en-us to https://learn.microsoft.com
  2. the ts change is followed by PR Add Azure Spring Apps as the target for azure windup-web#907

mrizzi
mrizzi reviewed Apr 11, 2023
View reviewed changes
Copy link
Member

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed changes checking them against previous comment from Antonio and added some further comments.

rules/rules-reviewed/azure/azure-file-system.windup.xml Outdated Show resolved Hide resolved
rules/rules-reviewed/azure/azure-file-system.windup.xml Outdated Show resolved Hide resolved
rules/rules-reviewed/azure/springboot/spring-boot-to-azure-database.windup.xml Outdated Show resolved Hide resolved
@showpune showpune mentioned this pull request Apr 12, 2023
Merged
@showpune
Copy link
Contributor Author

@mrizzi all the en-us references in URLs are removed

mrizzi
mrizzi approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@showpune thanks a lot for your first contribution 👏

@mrizzi mrizzi added Ready to Review auto-backport Set the PR for being backported auto-backport-to-releases/6.2.z Backport this issue to releases/6.2.z branch labels Apr 12, 2023
@mrizzi mrizzi merged commit 35c6001 into windup:master Apr 12, 2023
@github-actions github-actions bot mentioned this pull request Apr 12, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Apr 12, 2023
@showpune
Make rule spring boot rule available for spring apps (#918)
82fc053 
* Make rule spring boot rule avaliable for spring apps and update the doc link to azure spring apps

* Make rule spring boot rule avaliable for spring apps and update the doc link to azure spring apps

* Make rule spring boot rule avaliable for spring apps and update the doc link to azure spring apps

* Make rule spring boot rule avaliable for spring apps and update the doc link to azure spring apps

(cherry picked from commit 35c6001)
@github-actions
Copy link

💚 All backports created successfully

Status Branch Result
✅ releases/6.2.z

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

mrizzi pushed a commit that referenced this pull request Apr 12, 2023
@github-actions @showpune
Make rule spring boot rule available for spring apps (#918) (#921)
5455d1d 
* Make rule spring boot rule avaliable for spring apps and update the doc link to azure spring apps

* Make rule spring boot rule avaliable for spring apps and update the doc link to azure spring apps

* Make rule spring boot rule avaliable for spring apps and update the doc link to azure spring apps

* Make rule spring boot rule avaliable for spring apps and update the doc link to azure spring apps

(cherry picked from commit 35c6001)

Co-authored-by: Zhiyong Li <iamlizhiyong@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrizzi mrizzi mrizzi approved these changes

Assignees
No one assigned
Labels
auto-backport Set the PR for being backported auto-backport-to-releases/6.2.z Backport this issue to releases/6.2.z branch Ready to Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@showpune @agoncal @mrizzi