Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WINDUPRULE-969 Fix Hibernate target version range #910

Merged
merged 1 commit into from
Mar 24, 2023
Merged

WINDUPRULE-969 Fix Hibernate target version range #910

merged 1 commit into from
Mar 24, 2023

Conversation

mrizzi
Copy link
Member

@mrizzi mrizzi commented Mar 22, 2023 •
edited
Loading

@mrizzi mrizzi added auto-backport Set the PR for being backported auto-backport-to-releases/6.1.z Backport this issue to releases/6.1.z branch labels Mar 22, 2023
@mrizzi mrizzi requested a review from jmle March 22, 2023 13:19
@mrizzi mrizzi requested a review from m-brophy March 23, 2023 10:35
@PhilipCattanach
Copy link
Contributor

Changes look correct
Ran - ./windup-cli --input /home/pcattana/Repositories/windup-rulesets/rules/rules-reviewed/eap8/eap7/tests/data/hibernate-62 --target hibernate6 --output $HOME/MTA_Output/hibernate6shortcut
Then checked to ensure some of the the 6.2 rules had fired
And they had

@PhilipCattanach PhilipCattanach merged commit e3327cb into windup:master Mar 24, 2023
@github-actions github-actions bot mentioned this pull request Mar 24, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Mar 24, 2023
@mrizzi
WINDUPRULE-969 Fix Hibernate target version range (#910)
3b1cbff 
(cherry picked from commit e3327cb)
@github-actions
Copy link

💚 All backports created successfully

Status Branch Result
✅ releases/6.1.z

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@mrizzi mrizzi deleted the WINDUPRULE-969-fix branch March 24, 2023 09:18
mrizzi added a commit that referenced this pull request Mar 24, 2023
@github-actions @mrizzi
WINDUPRULE-969 Fix Hibernate target version range (#910) (#911)
0421702 
(cherry picked from commit e3327cb)

Co-authored-by: Marco Rizzi <mrizzi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmle jmle Awaiting requested review from jmle

@m-brophy m-brophy Awaiting requested review from m-brophy

Assignees
No one assigned
Labels
auto-backport Set the PR for being backported auto-backport-to-releases/6.1.z Backport this issue to releases/6.1.z branch Ready to Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrizzi @PhilipCattanach