Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WINDUPRULE-934 Added CDI Jakarta technology-tag #855

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

mrizzi
Copy link
Member

@mrizzi mrizzi commented Feb 14, 2023

https://issues.redhat.com/browse/WINDUPRULE-934

  • added Jakarta CDI identification rule
  • removed duplicated technology-usage-embedded-framework-05500
  • set CDI in the Inversion of Control box

PS: I've tried a lot for having just one rule covering both javax and jakarta root packages but it never worked as expected (I suspect due to WINDUP-1324.
The sample not-working rule I've tried with was (hint is there for the sake of having a quick feedback on reports):

        <rule id="javaee-technology-usage-00019">
            <when>
                <javaclass references="{ee-flavor}{enterprise}inject.{*}">
                    <location>IMPORT</location>
                </javaclass>
            </when>
            <perform>
                <hint title="found CDI" effort="13">
                    <message>found CDI in {ee-flavor}{enterprise}</message>
                </hint>
            </perform>
            <where param="ee-flavor">
                <matches pattern="(javax|jakarta)" />
            </where>
            <where param="enterprise">
                <matches pattern="(\.enterprise\.|\.)" />
            </where>
        </rule>

@mrizzi mrizzi added Ready to Review auto-backport Set the PR for being backported auto-backport-to-releases/6.1.z Backport this issue to releases/6.1.z branch labels Feb 14, 2023
@PhilipCattanach
Copy link
Contributor

Tested successfully

@PhilipCattanach PhilipCattanach merged commit dfbbaf8 into windup:master Feb 14, 2023
github-actions bot pushed a commit that referenced this pull request Feb 14, 2023
@github-actions
Copy link

💚 All backports created successfully

Status Branch Result
releases/6.1.z

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@mrizzi mrizzi deleted the WINDUPRULE-934-CDI branch February 14, 2023 12:09
mrizzi added a commit that referenced this pull request Feb 14, 2023
(cherry picked from commit dfbbaf8)

Co-authored-by: Marco Rizzi <mrizzi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Set the PR for being backported auto-backport-to-releases/6.1.z Backport this issue to releases/6.1.z branch Ready to Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants