Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag versions of Java EE based on deployment descriptors #846

Merged
merged 21 commits into from
Mar 2, 2023
Merged

Tag versions of Java EE based on deployment descriptors #846

merged 21 commits into from
Mar 2, 2023

Conversation

agoncal
Copy link
Contributor

@agoncal agoncal commented Feb 1, 2023

These rules check for the version number of Java EE deployment descriptors and tags the technology used (eg. EJB) and its version (eg. 3.2)

@agoncal
Copy link
Contributor Author

agoncal commented Feb 6, 2023

Wait for windup/windup#1587

@m-brophy
Copy link
Contributor

Running an analysis with the latest version of the rules against the test objects produces this index page:
image
(EJB, JPA and Servlet xml rules are now not needed because the java rules which should have previously provided the output required have been fixed)

@m-brophy
Copy link
Contributor

running against the previous version of test data files (ie including EJB, JPA and Servlet test data files) produces this output (note the tags produced by the java rules):
image

@agoncal
Copy link
Contributor Author

agoncal commented Feb 24, 2023

@m-brophy @mrizzi really good !!!

So, is it ready to be merged ?

Copy link
Member

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@m-brophy I've run a test and in technolgies report I can see all the new tech tags but JSF XML: can you add it as well please?

@PhilipCattanach
Copy link
Contributor

Thanks again @agoncal - This is a great addition to the rules.

@PhilipCattanach PhilipCattanach merged commit d2fdf07 into windup:master Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants