Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Winduprule-1030 #1022

Merged
merged 5 commits into from
Oct 13, 2023
Merged

Winduprule-1030 #1022

merged 5 commits into from
Oct 13, 2023

Conversation

m-brophy
Copy link
Contributor

https://issues.redhat.com/browse/WINDUPRULE-1030

kitchensink migration to quarkus 3 windup rules

Copy link
Contributor

@jmle jmle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @m-brophy I added some comments, but I think most of the stuff is covered. I'm not a Quarkus expert but looks good. Please tell me if any of my suggestions don't make sense.

@jmle jmle self-requested a review October 13, 2023 10:25
@jmle jmle merged commit 7969042 into windup:master Oct 13, 2023
26 checks passed
@PhilipCattanach PhilipCattanach added auto-backport Set the PR for being backported auto-backport-to-releases/6.3.z Backport this issue to releases/6.3.z branch and removed Ready to Review labels Oct 27, 2023
github-actions bot pushed a commit that referenced this pull request Oct 27, 2023
* kitchesink quarkus migration rules

* kitchensink migration rules tests

* add rule for junit

* jax-rs activation rule

(cherry picked from commit 7969042)
@github-actions
Copy link

💚 All backports created successfully

Status Branch Result
releases/6.3.z

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

PhilipCattanach pushed a commit that referenced this pull request Nov 16, 2023
* kitchesink quarkus migration rules

* kitchensink migration rules tests

* add rule for junit

* jax-rs activation rule

(cherry picked from commit 7969042)

Co-authored-by: Mark Brophy <36955467+m-brophy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Set the PR for being backported auto-backport-to-releases/6.3.z Backport this issue to releases/6.3.z branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants