[4.0] Update the help output and comments of the deleted file check to folder use #45
Conversation
|
So the problem is this does need to move back to git commit references :) that’s the missing part of my current PR that blocks it from being merged |
|
@wilsonge So this PR is wrong and I shall close it? Please confirm, then I'll close. But if so, then the help texts at following 2 places are wrong: https://github.com/wilsonge/joomla-cms/blob/deleted_file_rework/build/deleted_file_check.php#L45 https://github.com/wilsonge/joomla-cms/blob/deleted_file_rework/build/deleted_file_check.php#L56 Or do I understand something wrong still? |
|
Sorry for not replying. Yes the help texts should be updated as we work on the move back to use git properly |
|
Then take this PR as a reminder. Or should I make a new one here? |
|
Can do a new one to fix that other text if you want sure |
… and clean up sub-layouts (#45) * Separate link and button for dropdown items - Move dropdown handling to main layout override - Remove obsolete sub-layout overrides * Use language string for screenreader text * Add missing language string for frontend * Adapt metismenu scss to changed dropdown
Pull Request for joomla#25559.
Summary of Changes
When a parameter is missing, the help message which is shown in that case still talks about commit references to be used and not folders or directories.
I've deficed to use the wording "directory" at the end because in some help messages for missing parameters it was already used like this.
Some code comments do the same.
Testing Instructions
Code review.
Expected result
Correct comments and help output.
Actual result
Misleading comments and help output.
Documentation Changes Required
None.