The behavior of notificationReceived on Android is the same as iOS. #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gimdongwoo thank you submitting this PR. I'm closing this now in favor of #38 which incorporates your addition, but on top of that exposes everything in the payload that OneSignal sends. And yes, we don't distribute the zip file because the build process is automated based on git tags. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Android, additionalData must be present for notificationReceived event to occur.
Even if there is only Title and Body, it is need to fire event.
The iOS version in your module is working like that.
Because, I'm make to the behavior of notificationReceived on Android is the same as iOS.
I confirmed that I built it and it works, but your policy did not seem to upload the module zip file, so I omitted it.
Thank you!