Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Can't resolve 'ease' #10

Merged
merged 1 commit into from
Aug 25, 2018
Merged

Error: Can't resolve 'ease' #10

merged 1 commit into from
Aug 25, 2018

Conversation

willhoag
Copy link
Owner

@willhoag willhoag commented Aug 25, 2018

Pulled in all component dependencies in order to maintain a non-breaking status. Could use a rewrite with a bump to v3.0.0, but this makes sense as a first step.

Original Issue via @coreyward

Similar issue to #5, only this time with the component-tween dependency. Honestly, it's turtles all the way down; the component/___ libraries were really only meant to work for Component, which is now deprecated and no longer maintained.

It may make sense to switch to another tween library, like Tween.js, but it could also be fairly simple to hardcode the minimum viable code and eliminate deps altogether.

Copy link

@coreyward coreyward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resolves the errors for me!

If you wanted to cut down on extraneous code it would be trivial to drop the unused timing functions, but I suspect the build process will do it anyways.

@willhoag
Copy link
Owner

The ease functions are part of the API as you can choose the ease in the options object.

Q: Any thoughts on how I should version this? You can make an argument for Major, Minor and Patch for codebases that happen to utilize component/s since this increases the size a non-trivial amount.

@coreyward
Copy link
Author

Re: easing — I missed the options and just saw out-circ. 👍

Re: versioning — does this introduce any functional changes or would you consider it strictly a bugfix? If no functional changes, it's a patch. If there are functional changes, but they're backwards compatible, it's a minor version change. I suspect it's the former.

@willhoag
Copy link
Owner

That's how I usually treat versioning. Thinking it really depends on if you treat codesize as a functional feature of a module I guess. Do you know if Semver has an official stance on that?

@coreyward
Copy link
Author

Size isn’t functional, unless it impacts something else. It’s an implementation detail really.

@willhoag
Copy link
Owner

My thinking was that size isn't strictly an implementation detail as it affects load times, hard limits on less than capable devices etc. but in this case, it isn't egregiously larger ...so, I suppose I'll treat it as a patch. Thx. 👍

@willhoag willhoag merged commit f047fab into master Aug 25, 2018
@willhoag willhoag deleted the issue-10 branch August 25, 2018 22:01
willhoag added a commit that referenced this pull request Aug 25, 2018
Error: Can't resolve 'ease'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants