Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solara fails to import with Python 3.13 on Windows #797

Open
EwoutH opened this issue Sep 25, 2024 · 5 comments
Open

Solara fails to import with Python 3.13 on Windows #797

EwoutH opened this issue Sep 25, 2024 · 5 comments

Comments

@EwoutH
Copy link
Contributor

EwoutH commented Sep 25, 2024

When we were updating our CI setup (projectmesa/mesa#2325) we noticed that the Windows build threw some errors:

ERROR tests/test_cell_space.py - AttributeError: module 'solara' has no attribute 'component'.
ERROR tests/test_devs.py - AttributeError: module 'solara' has no attribute 'component'.
ERROR tests/test_solara_viz.py - AttributeError: module 'solara' has no attribute 'reactive'.
!!!!!!!!!!!!!!!!!!! Interrupted: 3 errors during collection !!!!!!!!!!!!!!!!!!!

Both Python 3.13 on macOS and Ubuntu and Python 3.12 on Windows run fine, it's only Python 3.13 on Windows that gives the errors.

Since the pip install step takes a lot longer, it could be that either Solara or a dependency of Solara is being build manually on Python 3.13 Windows instead of using a wheel, which could be causing the problems.

The Python 3.13.0 stable release is this Tuesday (2024-10-01), it might be nice if everything runs smoothly on stable release.

@EwoutH
Copy link
Contributor Author

EwoutH commented Sep 25, 2024

Issue reproduced on Solara's own CI: https://github.com/widgetti/solara/actions/runs/11027367292/job/30625621676?pr=798

image

ERROR: Cannot install jupyter-client because these package versions have conflicting dependencies.

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip to attempt to solve the dependency conflict

ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts

It seems like a relatively straightforward dependency conflict that just needs to be resolved.

@EwoutH
Copy link
Contributor Author

EwoutH commented Sep 26, 2024

Hi @maartenbreddels and @iisakkirotko! Python 3.12 stable is releasing in 5 days, any chance these issues can be given some priority? See also:

@iisakkirotko
Copy link
Collaborator

Hi @EwoutH! Unfortunately I'm at a conference for this week, so I won't be able to take a look at this before Monday. I do hope to work on it as soon as I'm back at the office, unless Maarten gets to it before I do.

@EwoutH
Copy link
Contributor Author

EwoutH commented Oct 1, 2024

Thanks for getting back.

Today is 3.13 release day, so if you have a chance, that would be appreciated!

iisakkirotko added a commit that referenced this issue Oct 1, 2024
This will take us most of the way towards supporting Python 3.13, see #797 for progress.
iisakkirotko added a commit that referenced this issue Oct 1, 2024
This will take us most of the way towards supporting Python 3.13, see #797 for progress.
@iisakkirotko
Copy link
Collaborator

Hi again @EwoutH! I had a look at this yesterday, and made some improvements to hopefully speed the support along (see #804). The core functionality seems work properly, but installing solara[all] will still fail (more on that below). Note that this would put you on jupyterlab==2.3.2.

For full support, I think we have to wait for vaex to support Python 3.13, as well as microsoft/playwright-python#2565, apache/arrow#43519, and openai/tiktoken#346 to be released. To use a modern version of Jupyterlab on windows, we need to wait for pywin32 to support python 3.13 (see mhammond/pywin32#2367).

maartenbreddels pushed a commit that referenced this issue Oct 1, 2024
This will take us most of the way towards supporting Python 3.13, see #797 for progress.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants